Allowing PUT / POST without request body data #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm. I like it. The existing behavior isn't very convenient if you're POSTing with null data a lot. And I don't think your changes will be a big deal for people. After all, if you want to just type the data in when doing a POST you can always do something like which is fine as far as I'm concerned. I think I'll merge you in and if anyone complains we can rethink how to fix it. Thanks! |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I often find myself doing a PUT or a POST only specifying options - not specifying request body data at all. This patch will only read from stdin if it's a pipe.
This does break the ability to just type in data when doing a POST, so maybe you're not okay with that. If that's the case, this this could maybe be an option to PUT or POST?